[buddypress-trac] [BuddyPress Trac] #4824: Autocomplete
buddypress-trac
noreply at wordpress.org
Thu May 19 08:47:06 UTC 2016
#4824: Autocomplete
-----------------------------------+-----------------------
Reporter: stefwilliams | Owner:
Type: defect (bug) | Status: reopened
Priority: normal | Milestone: 2.6
Component: Component - Messaging | Version: 2.5.0
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+-----------------------
Comment (by DJPaul):
You didn't attach the patch, but looking at the code, it's pretty clear
that jquery.autocomplete.js is a third-party script, albeit an old one
dating back to BuddyPress 1.0. If we went this way, we'd have to change
`messages_autocomplete_init_jsblock` as that's the one place in core where
we call this script. The root problem is a badly? named jQuery module, but
I don't know if this script predates jQuery UI's or vice-versa (they must
both date from around the same time).
I am generally against modifying third party scripts for this kind of
reason, even scripts we're working towards deprecating (see: the at-
mentions JS).
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4824#comment:13>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list