[buddypress-trac] [BuddyPress Trac] #6308: bp_settings_action_general() could be broken down into smaller functions

[buddypress-trac]

#6308: bp_settings_action_general() could be broken down into smaller functions
----------------------------------+-----------------------------
 Reporter:  henry.wright          |       Owner:
     Type:  enhancement           |      Status:  new
 Priority:  normal                |   Milestone:  Future Release
Component:  Component - Settings  |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  good-first-bug        |
----------------------------------+-----------------------------

Comment (by needle):

 Replying to [comment:3 DJPaul]:
 > I think new functions hooked, that deal with one aspect.

 My hesitation regarding this approach is that:

 1. feedback would be limited to ''either'' email errors ''or'' password
 errors, not both as is currently the case.
 2. it would be tricky to return the "No changes were made to your
 account." feedback
 3. `wp_update_user()` would be called twice
 4. it's not clear where the `bp_core_general_settings_after_save` hook
 should live

 Other than that, I agree with you :-)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6308#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac