[buddypress-trac] [BuddyPress Trac] #6210: Create New Invitations API

[buddypress-trac]

#6210: Create New Invitations API
--------------------------+-----------------------------
 Reporter:  dcavins       |       Owner:  dcavins
     Type:  task          |      Status:  accepted
 Priority:  low           |   Milestone:  Future Release
Component:  API           |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  dev-feedback  |
--------------------------+-----------------------------

Comment (by dcavins):

 I've just added a new "progress" patch. In it, I've worked out many of the
 details of saving, updating and retrieving invitations from the new
 invitations table and switched BP groups to use the new core functions for
 their invitations and requests. There are plenty of places I see to make
 improvements, like letting the group invites rely on default core invite
 behavior more.

 The biggest questions mark for me is that this change removes pending
 members from the groups_members table. It seems like a nice improvement,
 but it really messes with `BP_Groups_Member_Query`. I'd love some feedback
 on how this could work more smoothly--I hacked something together but I
 have doubts. Many tests are failing because of how group invites are
 created in the tests (`new BP_Group_Member( $args )`), which could be
 fixed in the tests, but, geez, are people in the wild using the BP Group
 Member class in that way? If so, this idea just got harder. :)

 Also feedback on my caching mechanisms would be very helpful (especially
 the bits where I'm filtering lists of invitations to avoid making more
 database calls). Of course, any feedback is helpful--this is a big lump of
 code changes.

 Moving to a new table will also require an upgrade method, which is still
 to be worked out.

 Thanks for your comments!

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6210#comment:16>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac