[buddypress-trac] [BuddyPress Trac] #6534: A new API to manage single items navigation

[buddypress-trac]

#6534: A new API to manage single items navigation
------------------------------------+------------------
 Reporter:  imath                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  high                    |   Milestone:  2.6
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------

Comment (by imath):

 Hi @boonebgorges

 Thanks a lot for your great improvements. I confirm the unit tests and the
 front end tests you shared are working fine for me.

 I've noticed you iterated from r-a-y's version of the patch. So i have
 questions... Why defining the $bp->options_nav again inside the groups
 component? If i comment this part in `bp-groups/classes/class-bp-groups-
 component.php`, your patch is still working:
 {{{
 // Backward compatibility for plugins modifying the legacy bp_options_nav
 global property.
 /*if ( buddypress()->do_nav_backcompat ) {
         $bp->bp_options_nav = new BP_Core_BP_Options_Nav_BackCompat();
 }*/
 }}}

 Do we really need to reset `$bp->options_nav` as it was already set in the
 members component ?

 About the deprecated functions, what is the reason that makes these
 functions different than other deprecated functions since r-a-y and you
 are adding a trace to the deprecated notice ? My point is why doing it
 here and not for all deprecated functions ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6534#comment:26>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac