[buddypress-trac] [BuddyPress Trac] #6772: BuddyPress Embeds for activity, user profiles, groups

buddypress-trac noreply at wordpress.org
Thu May 5 22:58:28 UTC 2016

#6772: BuddyPress Embeds for activity, user profiles, groups
 Reporter:  imath                   |       Owner:
     Type:  idea                    |      Status:  new
 Priority:  normal                  |   Milestone:  2.6
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |

Comment (by imath):

 Hi @r-a-y

 First i'd like to say you did a really great work on this ticket. I've
 really tried to convert myself about "embed in embed", to prove it here's
 the beginning of a suggestion patch i was about to make ->
 [https://gist.github.com/imath/43105d0241c330f6a12ba01044b672b7 gist]

 But after embedding an activity containing a youtube video or a vimeo
 video into a post, this is what i got:

 The 2 videos refused to display or play because of a cross domain issue.
 So i definitively think we shouldn't try to iframe an iframe! Because
 anyway we can't see the content.

 Then, attaching the inline embed css to open-sans might not be a good
 idea, because for some reason, WordPress 4.6 is not including the css
 anymore, meaning the embed css is not attached :(

 Then, i think we should use the Activity action as the title of the embed,
 as it gives a nice piece of information when for instance an activity is
 posted within a group.

 Finally i understand the will to display some content for the embed so i'm
 suggesting to fetch the image of it so that's it's better than nothing ;)
 And image added to activity would also be represented using this

 So after applying your patch, i've quickly drafted what i have in mind an
 put it into 6772.07.suggestions.patch (attached to this ticket)
 NB: you'll first need to apply 6772.07.patch

 And here's some before after:


 A Group activity containing an image

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6772#comment:30>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list