[buddypress-trac] [BuddyPress Trac] #6712: Screen notifications settings page

buddypress-trac noreply at wordpress.org
Wed May 4 20:08:25 UTC 2016

#6712: Screen notifications settings page
 Reporter:  r-a-y                      |       Owner:
     Type:  enhancement                |      Status:  new
 Priority:  normal                     |   Milestone:  2.6
Component:  Component - Notifications  |     Version:  1.9
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch                |

Comment (by r-a-y):

 Thanks for the feedback everyone.

 > 1) The existing "[user] > Settings > Emails" screen should encompass
 both Emails and Toolbar notifications.


 > I'm not intending to de-rail this ticket by saying "we shouldn't build
 this until we have that other thing done", but just that consideration is
 given to this future goal so we can make the best decisions for today
 without stitching ourselves up in the future.

 I was thinking about merging the Screen Notications page myself.  The
 problem is our current "Settings > Email" API is quite terrible.

 If we believe that there should be just one Notification settings page
 that encompasses Emails, Screen Notifications (and potentially more), we
 should only add this functionality once we figure out how to handle
 outputting and saving existing Email settings and figuring out a system
 that would work for third-party components as well.

 I'm not sure what can be done here.

 #6932 actually proposes a schema to handle registering email notification
 metakeys, but that would only work for core emails.  Existing plugins
 using the `'bp_notification_settings'` `<table>` hook would not be
 displayed.  I'm not sure if it is possible to maintain backward

 If we want to merge the Email and Screen Notification settings pages, it's
 most likely that this will have to move to Future Release.

 Adding a separate settings page and merging it later will infuriorate many
 BuddyPress installations.

 > but, testing the patches and visually speaking the new screen on
 twentyfifteen tended to leap out at me due to a lot of components without
 actions so just a heading and checkbox/label.

 Yeah, I made the decision to output any component that has registered
 itself with notifications support.  We can decide to only show components
 that have registered notification actions if that is better for UX.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6712#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list