[buddypress-trac] [BuddyPress Trac] #6932: Emails: real unsubscribe functionality

buddypress-trac noreply at wordpress.org
Mon May 2 23:56:26 UTC 2016


#6932: Emails: real unsubscribe functionality
----------------------------------------+---------------------------
 Reporter:  DJPaul                      |       Owner:  tharsheblows
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  2.6
Component:  API - Emails                |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+---------------------------

Comment (by DJPaul):

 >  It seems to me that this data is a property of the *type*

 Yes.

 > You're running URLs through esc_url() before sending them to email.

 I forget the conversation, but I think we need to use `esc_url_raw()`
 here. We'll catch any issues with this in testing.

 > bp_email_get_type_schema(), etc

 BP functions that return data should use "get" in their names. i.e. your
 new `bp_email_type_schema()`. :)
 Maybe add optional parameter to existing function and use that to choose
 what data is returned? e.g. "old data", "new data", "everything". ??

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6932#comment:18>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list