[buddypress-trac] [BuddyPress Trac] #6772: BuddyPress Embeds for activity, user profiles, groups

buddypress-trac noreply at wordpress.org
Mon May 2 03:48:45 UTC 2016


#6772: BuddyPress Embeds for activity, user profiles, groups
------------------------------------+------------------
 Reporter:  imath                   |       Owner:
     Type:  idea                    |      Status:  new
 Priority:  normal                  |   Milestone:  2.6
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+------------------

Comment (by r-a-y):

 `07.patch` is updated to use the new WP 4.5 embed templates.  This bumps
 the requirement for BP embeds to WP 4.5.

 Since most themes will use WP's included `wp-includes/theme-
 compat/embed.php` file for the embed template, I'm also making sure we
 will be using this.  However, to override WP's `get_template_part(
 'embed', 'content' )` call in the `embed.php` template, I'm doing some
 object buffering to manually wipe out the markup generated by the `embed-
 content.php` template and injecting our BP embed content there.  See
 `BP_oEmbed_Component::setup_template_parts()` for more info.

 Some work still needs to be done to the embed template for activity items
 with no content, but we can revisit this when my comments in comment:21
 are looked at.

 ----

 To answer imath's questions from comment:26:

 > the embed activity was deleted

 In this instance, the iframe content will use WP's embed 404 template.

 > the embed activity was posted inside a private/hidden group the current
 user has not access to.

 Attempting to embed a private activity will render just the activity
 permalink.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6772#comment:27>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list