[buddypress-trac] [BuddyPress Trac] #6534: A new API to manage single items navigation

buddypress-trac noreply at wordpress.org
Sun May 1 19:17:19 UTC 2016

#6534: A new API to manage single items navigation
 Reporter:  imath                   |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  high                    |   Milestone:  2.6
Component:  API                     |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |

Comment (by imath):

 Thanks a lot @r-a-y for your feedback.

 About point7: your version of the patch is only making sure editing the
 nav is working, because if i add this line to your snippet:
 var_dump( buddypress()->bp_nav['activity']['link'] );

 I'm getting a null value although it's set. In previous patch, i worked on
 setting new navs directly and your version removed it :(

 More globally point 7 will be a real pain, because ArrayAccess *is not
 designed* to take care of multidimensional arrays. So i feel this
 backcompat class will be a never ending story. So i doubt we'll ever have
 this ticket fixed if we need to take care of any backcompat issue for
 people playing directly with vars instead of using available functions or

 But so be it! 6534.04.patch should fix the issue you shared without
 creating new `buddypress()` global vars ;)

 > I also fixed a bug with the user's "Profile" nav not showing up and
 added a debug trace to the deprecated nav functions so devs can easily
 find out where the deprecated nav calls are coming from.
 It's only happening when viewing another user's profile. Good catch. I've
 included your fix in 04.patch (i've spent an hour finding it as svn is
 formatting the diffs differently than git!)

 About the trace thing. I haven't included it in 04.patch. Although I think
 it's interesting, why doing this for these specific deprecated functions
 and not the others ?
 (ideally i think it should live in an upstream ticket)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6534#comment:23>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list