[buddypress-trac] [BuddyPress Trac] #6959: Use is_default_field() everywhere instead of comparing to 1

[buddypress-trac]

#6959: Use is_default_field() everywhere instead of comparing to 1
----------------------------------+-----------------------
 Reporter:  slaFFik               |       Owner:  slaFFik
     Type:  task                  |      Status:  assigned
 Priority:  normal                |   Milestone:  2.6
Component:  Component - XProfile  |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-patch           |
----------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  dev-feedback has-patch 2nd-opinion => needs-patch


Comment:

 I agree that we should not be hardcoding this, and I think it's an OK idea
 to have a wrapper function for this purpose.

 But there is a long and awful history here, so I want to be careful not to
 cause more problems. See #3725 (especially [5778]) and [7812]. We should
 probably be consolidating on the use of `bp_xprofile_fullname_field_id()`
 rather than `1`.

 @slaFFik Can you chew on those tickets and changesets and see what you
 think?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6959#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac