[buddypress-trac] [BuddyPress Trac] #6969: BP Emails - friendship accepted email is not sent

[buddypress-trac]

#6969: BP Emails - friendship accepted email is not sent
------------------------------+---------------------
 Reporter:  shanebp           |       Owner:  r-a-y
     Type:  defect (bug)      |      Status:  closed
 Priority:  normal            |   Milestone:  2.5.2
Component:  API - Emails      |     Version:  2.5.0
 Severity:  normal            |  Resolution:  fixed
 Keywords:  has-patch commit  |
------------------------------+---------------------
Changes (by r-a-y):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10683"]:
 {{{
 #!CommitTicketReference repository="" revision="10683"
 Friends: Fix issue with friendship accepted email not being sent.

 Previously, the `$initiator_id` variable in
 ``friends_notification_accepted_request()`
 was a numeric string.  The `BP_Email_Recipient` class can only handle
 strict integers, which prevented friendship accepted emails from being
 sent.

 For 2.5-branch, this commit casts `$initiator_id` variable as an integer
 to fix the immediate problem.  A broader solution to audit all our access
 methods and functions to ensure that numeric strings are cast as
 integers will be implemented in a future release.

 Fixes #6969 (2.5-branch).
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6969#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac