[buddypress-trac] [BuddyPress Trac] #6719: Activity link moderation doesn't output useful error message to end users

[buddypress-trac]

#6719: Activity link moderation doesn't output useful error message to end users
------------------------------------+-----------------------
 Reporter:  r-a-y                   |       Owner:  r-a-y
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.6
Component:  General - UX/UI         |     Version:  1.6
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |
------------------------------------+-----------------------

Comment (by hnla):

 @r-a-y
 Tested refreshed patch. This is a vast improvement on what we had and
 addresses some of the concerns raised in #6822 vis a vis:

 * ''Add a status update, exceed links allowed, receive error message,
 however the status update is actually accepted and displayed with no
 actual moderation and we can see the update in user screens and members
 loops. ''

 Now we have stronger  messages highlighting the exact reason.

 For links we halt and notify there are too many however now it's clearer
 why the error and we do NOT publish those links regardless as we were
 before, user does have the option to review those links and amend as we
 have retained the textarea data.

 We correctly stop blacklisted words from being displayed, although we
 still do not add the comment to the WP moderation queue - this behaviour
 is better than posting the comment though.

 For WP spam list words we do not trap those and do publish them although
 these are meant to be held too.

 Posting a comment to a WP post from the act stream is still problematical
 we acknowledge an issue with the comment but not what i.e  bad-word, spam-
 word, or too many links.

 Having thrown up the error message  and not posted the comment in the act
 stream we find that in visiting the post in question directly the comment
 has been posted bypassing the WP moderation queue.

 I think we have a real issue here in providing a means to circumvent the
 WP process and user set blacklists, links etc.

 The error message provision doesn't tackle that aspect although it does
 improve the BP status update behaviour and puts in place a proper WP_Error
 handling class?


 imho I do think we still need to either pull moderation altogether until
 we can correct things or decide to tackle this fully but I would like my
 cake and eat it and add the patch here as it does start to put in place
 proper error handling?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6719#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac