[buddypress-trac] [BuddyPress Trac] #6937: fatal error when trashing emails

[buddypress-trac]

#6937: fatal error when trashing emails
-------------------------------+--------------------
 Reporter:  DJPaul             |       Owner:
     Type:  defect (bug)       |      Status:  new
 Priority:  normal             |   Milestone:  2.5.1
Component:  Component - Blogs  |     Version:  2.5.0
 Severity:  normal             |  Resolution:
 Keywords:  has-patch          |
-------------------------------+--------------------
Changes (by imath):

 * keywords:  has-patch needs-testing => has-patch


Comment:

 So here's a detailled explanation

 In r10544 we did two things:
 - Only load `bp-blogs/bp-blogs-activity.php` if the Activity Component was
 active
 - Remove the `bp_is_active( 'activity' )` checks inside
 `bp_blogs_record_activity()` and `bp_blogs_delete_activity()`

 This means before this commit, the file was loaded and the checks were
 making sure the activity component was active before using an Activity
 component function. Reason why this trouble appeared in 2.5.0 and not
 before.

 I keep on thinking only loading the `bp-blogs/bp-blogs-activity.php` if
 the Activity Component is active is a good improvement as it avoids
 loading a bunch of code that is not used anyway. But this means we now
 need to do the `bp_is_active( 'activity' )` before using
 `bp_blogs_record_activity()` or `bp_blogs_delete_activity()`.

 That's what is doing
 [https://buddypress.trac.wordpress.org/attachment/ticket/6937/6937.patch
 6937.patch]. I've tested it having the Blogs component active and the
 Activity one deactivated on multisite/non multisite and it's fixing the
 issue.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6937#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac