[buddypress-trac] [BuddyPress Trac] #6931: Cover Image location is incorrect for blogs other than the primary blog

[buddypress-trac]

#6931: Cover Image location is incorrect for blogs other than the primary blog
----------------------------------+-----------------------------
 Reporter:  rbaccaro              |      Owner:
     Type:  defect (bug)          |     Status:  new
 Priority:  highest               |  Milestone:  Awaiting Review
Component:  Component - XProfile  |    Version:  2.4.0
 Severity:  critical              |   Keywords:  needs-patch
----------------------------------+-----------------------------
 Scenario:

 - multisite
 - BP is network activated
 - define( 'BP_ENABLE_MULTIBLOG', true ) is set
 - fresh and new installation
 - only BP installed as plugin
 - default theme

 The image cover path and url are using the current blog location as for
 example
 "/uploads/sites/[BLOG_ID]/buddypress/members/[USER_ID]/cover-image/".

 When the same user goes to a different blog, his cover image is not
 fetched, making the same user to be able to have more than one cover
 image, visiting different blogs.

 '''I think BP's intention is to have a single cover image per user/group
 across the network of blogs, and therefore the upload location for the
 primary blog should be used for any blog in the network.'''

 IMHO, it does not make sense to have more than one location for cover
 images, since wp_users and wp_usermeta are tables with fields shared
 across the network as well as xprofile component.

 BP had this same issue before when introduced avatar as solved by this
 ticket [https://buddypress.trac.wordpress.org/ticket/2317].

 For example, on my testing:

 Blog 1: CORRECT path for a network activated BP:

 – /wp-content/uploads/buddypress/members/[USER_ID]/cover-image/....-bp-
 cover-image.png

 Blog 2: WRONG path for a network activated BP:

 – /wp-content/uploads/sites/[BLOG_ID]/buddypress/members/[USER_ID]/cover-
 image/....-bp-cover-image.png

 Note that "/sites/[BLOG_ID]" is included on blog 2, which makes impossible
 to share the cover image across the network.

 '''IMHO, BP needs to remove '/sites/[BLOG_ID]' from upload path and url
 when is a multisite installation, BP network activated and
 BP_ENABLE_MULTIBLOG is true.'''

 I guess that the BP cover image file core that need to be fixed is located
 here
 https://github.com/buddypress/BuddyPress-build/blob/master/bp-core/classes
 /class-bp-attachment-cover-image.php

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6931>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac