[buddypress-trac] [BuddyPress Trac] #7146: Activity permalink access doesn't work with legacy activity query

[buddypress-trac]

#7146: Activity permalink access doesn't work with legacy activity query
--------------------------+--------------------
 Reporter:  r-a-y         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  2.6.1
Component:  Activity      |     Version:  2.6.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Description changed by r-a-y:

Old description:

> In #7113, we fixed a bug where anybody's activity item could be displayed
> under a member profile.
>
> However, due to the strict activity ID check here, this broke:
> https://buddypress.trac.wordpress.org/browser/tags/2.6.0/src/bp-activity
> /bp-activity-screens.php?marks=253#L252
>
> `$activity->user_id` is a string in some instances.
>
> #6977 marks ongoing work to cast all our numeric strings as integers.
> r10853 missed an instance in the older, legacy activity in
> `BP_Activity_Activity::get()`, which caused the problem.
>
> Attached patch fixes this up.

New description:

 In #7113, we fixed a bug where anybody's activity item could be displayed
 under a member profile.

 However, due to the strict activity user ID check for the fix, this broke
 activity permalink access on some installs:
 https://buddypress.trac.wordpress.org/browser/tags/2.6.0/src/bp-activity
 /bp-activity-screens.php?marks=253#L252

 `$activity->user_id` is a string when the older
 `'bp_use_legacy_activity_query'` filter is set to true via a plugin.

 #6977 marks ongoing work to cast all our numeric strings as integers.
 r10853 missed an integer casting instance in the older, legacy activity
 query, which caused the problem.

 Attached patch fixes this up.

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7146#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac