[buddypress-trac] [BuddyPress Trac] #4990: Error message after log out

[buddypress-trac]

#4990: Error message after log out
-------------------------------+----------------------
 Reporter:  henrywright        |       Owner:
     Type:  defect (bug)       |      Status:  closed
 Priority:  normal             |   Milestone:
Component:  Component - Core   |     Version:  1.7
 Severity:  normal             |  Resolution:  invalid
 Keywords:  reporter-feedback  |
-------------------------------+----------------------

Comment (by r-a-y):

 > Why, exactly, does BuddyPress need to add the wp_shake_js function to
 the login_head hook? This is already done in wp-login.php where it
 applies...

 Good question.  It's because the `'shake_error_codes'` filter runs too
 early in `wp-login.php`.  It runs before our custom error is even added:
 https://core.trac.wordpress.org/browser/tags/4.5.2/src/wp-
 login.php?marks=42-43,47-54,56-57,171-175#L42

 I haven't taken a look at your plugin, but BuddyPress is using the hooks
 made available on the WP login page.

 How do you handle `wp_shake_js()` for regular login errors like
 `empty_password` or `empty_email`?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/4990#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac