[buddypress-trac] [BuddyPress Trac] #6932: Emails: real unsubscribe functionality

buddypress-trac noreply at wordpress.org
Thu Jun 2 13:18:27 UTC 2016

#6932: Emails: real unsubscribe functionality
 Reporter:  DJPaul                      |       Owner:  tharsheblows
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  2.7
Component:  API - Emails                |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |

Comment (by tharsheblows):

 @DJPaul I think that comment should be "order *shouldn't* matter". The
 ksort sorts it so if the keys are out of order in the array, it's still
 ok. I think this makes sense but am not entirely sure on that.

 I've added a couple of unit tests, one for bp_hash_array and one for
 bp_email_get_salt. There were a couple of typos so I fixed those and
 changed md5 to sha1. I haven't tested overall functionality though of
 6932.8.diff though.

 I'd feel better if this had unit tests for each thing it unsubscribed. Is
 this worth doing or not necessary? I'll do it but thought I'd ask first!

 Also #7045 should go be looked at to go in 2.6. The reason I added it to
 this was to test them together and for ease of merging.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6932#comment:30>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list