[buddypress-trac] [BuddyPress Trac] #6844: Extract & relocate core markup functions: Theme compat include functionality & search forms file

[buddypress-trac]

#6844: Extract & relocate core markup functions:  Theme compat include
functionality & search forms file
-----------------------------------------+-----------------------
 Reporter:  hnla                         |       Owner:  hnla
     Type:  enhancement                  |      Status:  assigned
 Priority:  normal                       |   Milestone:  2.7
Component:  Appearance - Template Parts  |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  needs-patch                  |
-----------------------------------------+-----------------------
Changes (by boonebgorges):

 * keywords:  dev-feedback commit => needs-patch
 * milestone:  2.6 => 2.7


Comment:

 I was about to commit this, but there are a couple of issues that need to
 be cleared up first. Somehow, the patch was generated in such a way that
 the new template is repeated three times. And there are a bunch of
 instances of `esc_html_e()` that have nothing to do with translation, so
 should be changed to the proper function (`echo esc_attr()`, I guess).

 Waiting may also give us time to coalesce around a directory name.
 `common` is what's used here, and it's what I prefer, but I believe there
 has been near-endless discussion of a related issue in the bp-nouveau
 group.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6844#comment:22>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac