[buddypress-trac] [BuddyPress Trac] #6677: Groups: Draft, Locked or Suspended status

buddypress-trac noreply at wordpress.org
Thu Jul 28 09:19:45 UTC 2016

#6677: Groups: Draft, Locked or Suspended status
 Reporter:  dcavins                 |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Future Release
Component:  Groups                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |

Comment (by imath):

 Thanks a lot @dcavins for your great work on this feature. I haven't
 tested the patch but here are my global point of view about this feature.
 I must say i feel using capabilities for groups is not right. If we look
 at WordPress post status. The logic is a bit different and i think it's
 the good one. Post status have properties eg:
 - label
 - internal
 - _builtin'
 - label_count
 - show_in_admin_status_list
 - private
 - protected
 - public
 - exclude_from_search
 - etc

 And it's the user's cap that tels if he can read or write the post having
 a specific status for instance. I think we should probably have the same

 eg: `bp_groups_user_can( $user_id, 'join_group', array( 'group' => $group
 ) )`

 Then you could check inside the list of status properties
 (anyone_can_join, accepts_membership_requests...).

 Then i think we shouldn't develop a specific property for the retired
 forum component eg: `post_in_forum`. You can provide a specific filter but
 it should follow the generic restrictions.

 Finally i'm not sure to understand what the status property of the group
 became. IMHO $group->status should always return the "id " of the status
 eg: public, private, hidden or whatever and then we can get the detailed
 properties of this status by using the global group status object, no ?
 Meaning if a plugin do stuff with this status it should still work? Why
 would we need to check the BuddyPress version ?

 FYI there's a var_dump in src/bp-groups/bp-groups-template.php at line
 3196 of your patch

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6677#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list