[buddypress-trac] [BuddyPress Trac] #6482: Comment syncing between activity and post comments for Custom Post Types

[buddypress-trac]

#6482: Comment syncing between activity and post comments for Custom Post Types
------------------------------------+-----------------------
 Reporter:  shanebp                 |       Owner:  imath
     Type:  enhancement             |      Status:  assigned
 Priority:  normal                  |   Milestone:  2.5
Component:  Component - Blogs       |     Version:  2.2
 Severity:  normal                  |  Resolution:
 Keywords:  dev-feedback has-patch  |
------------------------------------+-----------------------

Comment (by imath):

 In 6482.06.patch i'm getting rid of the new activity meta, so we don't
 need the upgrade routine anymore.

 As discussed in dev-chat, the activity meta name used to reference the
 comment ID is now dynamic `"bp_blogs_{$post_type}_comment_id"`. I've added
 a new property to the activity tracking argument of an activity type to
 easily get this $post_type value and a new function to get a tracking arg
 value according to the activity type
 `bp_activity_post_type_get_tracking_arg()`.

 In some places, we use to check if the activity meta
 `"bp_blogs_post_comment_id"` to figure out if the activity_comment was
 synced with a post comment. As this meta name is now dynamic, i had no
 other choices than to get the parent activity ID.

 @r-a-y & @boone : feedbacks very welcome ;)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6482#comment:31>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac