[buddypress-trac] [BuddyPress Trac] #6803: Improve mobile view of the BuddyPress Components panel

buddypress-trac noreply at wordpress.org
Mon Jan 25 12:57:17 UTC 2016


#6803: Improve mobile view of the BuddyPress Components panel
----------------------------------------------+-----------------------
 Reporter:  mercime                           |       Owner:  mercime
     Type:  enhancement                       |      Status:  assigned
 Priority:  normal                            |   Milestone:  2.5
Component:  General - UX/UI                   |     Version:
 Severity:  normal                            |  Resolution:
 Keywords:  has-patch has-screenshots commit  |
----------------------------------------------+-----------------------
Changes (by DJPaul):

 * keywords:  has-patch has-screenshots => has-patch has-screenshots commit


Comment:

 Looks fantastic! Patch is also great, there is one small improvement you
 could make here:

 `<label for="bp_components[<?php echo esc_attr( $name ); ?>]" class
 ="screen-reader-text"`

 To

 `<label for="<?php echo esc_attr( "bp_components[$name]" ); ?>" class
 ="screen-reader-text"`

 It's slightly easier to read if the entire property is being escaped,
 rather than just the dynamic part.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6803#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list