[buddypress-trac] [BuddyPress Trac] #6482: Comment syncing between activity and post comments for Custom Post Types

[buddypress-trac]

#6482: Comment syncing between activity and post comments for Custom Post Types
--------------------------------------------------+-----------------------
 Reporter:  shanebp                               |       Owner:  imath
     Type:  enhancement                           |      Status:  assigned
 Priority:  normal                                |   Milestone:  2.5
Component:  Component - Blogs                     |     Version:  2.2
 Severity:  normal                                |  Resolution:
 Keywords:  needs-testing dev-feedback has-patch  |
--------------------------------------------------+-----------------------

Comment (by imath):

 Thanks a lot @r-a-y for your feedback and suggestions. Here's .04.patch :)

 Replying to [comment:23 r-a-y]:
 > '''1. action vs. type'''
 I've removed all references to 'action' in favor of 'type' where the term
 action was wrongly used ( meaning i've kept all stuff relative to action
 strings).

 > '''2. bp_activity_action_is_post_tracking_action( $action_id ) and
 bp_activity_action_supports_comments_tracking( $action_id ) functions'''

 At first, because 3 weeks passed, i thought it was a great idea. i even
 thought about using 'comment-reply' as a support check. But i'm not
 feeling good about using it as a generic function to check if an activity
 type supports a feature or not.

 These functions are there to check if the Activity type is about a
 WordPress Post Type supporting comments. So i see no objections having
 only one function instead of 2, but i think the name should then look like
 `bp_activity_post_type_supports`.

 For instance, i've tried to use your idea for the activity_comment support
 for any activity, and i gave up because of a headache. So i suppose
 this/these are very specific to *Post Type* Activity types :)

 > '''3. Performance tweaks when the activity component is not active.'''

 I agree, this is a very nice improvement. Added it to 04.patch :)


 > '''4. Creating an activity item for an existing WordPress post.'''
 > This isn't really related to comment tracking
 `^^` Absolutely. I've created #6834 for this.

 > '''Questions:'''
 >
 > '''1. Should we move the majority of the "Post Comment Synchronization"
 function hooks from bp-blogs-activity.php to the Activity component (under
 bp-activity-actions.php)?'''

 As long as the component is known as the "Site tracking" component, i
 think we should keep some code relative to site tracking in it. But i'm
 not strongly opposed about it :)

 > '''2. Potential problem with wp_new_comment()'''

 Is this problem introduced by the patch ? Or is it existing since the
 introduction of synchronization ?

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6482#comment:24>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac