[buddypress-trac] [BuddyPress Trac] #6822: Suspension of BP comment moderation functionality

[buddypress-trac]

#6822: Suspension of BP comment moderation functionality
----------------------------------+------------------
 Reporter:  hnla                  |       Owner:
     Type:  defect (bug)          |      Status:  new
 Priority:  normal                |   Milestone:  2.5
Component:  Component - Activity  |     Version:
 Severity:  normal                |  Resolution:
 Keywords:  needs-patch           |
----------------------------------+------------------
Description changed by hnla:

Old description:

> Following on from two tickets #6821 & #6719 and investigation of current
> BP behaviour it appears we have a problematic set of functionality when
> checking comments for allowed number of links as configured from the WP
> Discussion settings.
>
> Currently our issues are broadly:
>
> * Lack of a meaningful error message when exceeding permitted number of
> links in a comment or status update.
> * Silent destruction of entered data with no means of retrieving.
> * Inability to properly follow WP queued pending approval of comments.
> * Lack of any actual moderation - despite error message - when posting a
> status update; the update will be displayed despite exceeding  max number
> of links set and generating the warning message.
>
> Our actions result in:
> * Post a comment to a post, WP queues this for approval, approve the
> comment to publish it, check activity stream to find no comment added.
> * Post comment as a subscriber from the activity stream to a post, exceed
> the allowed links, receives the error message and no comment posted,
> check the WP dashboard comment is listed but listed as 'Approved',
> contrary to what should be seen as a comment pending. Regardless of the
> comment existing in WP terms and approved it will never figure in
> activity stream.
> * Add a status update, exceed links allowed, receive error message,
> however the status update is actually accepted and displayed with no
> actual moderation and we can see the update in user screens and members
> loops.
>
> Given that `bp_core_check_for_moderation` isn't ready for prime time
> currently or at least the checks on act stream and updates are not able
> to tie into the WP queued pending approval the wise course of action is
> probably to pull this functionality altogether until #6719 can be
> addressed.
>
> A patch will be added to remove `bp_check_for_moderation()`

New description:

 Following on from two tickets #6821 & #6719 and investigation of current
 BP behaviour it appears we have a problematic set of functionality when
 checking comments for allowed number of links as configured from the WP
 Discussion settings.

 Currently our issues are broadly:

 * Lack of a meaningful error message when exceeding permitted number of
 links in a comment or status update.
 * Silent destruction of entered data with no means of retrieving.
 * Inability to properly follow WP queued pending approval of comments.
 * Lack of any actual moderation - despite error message - when posting a
 status update; the update will be displayed despite exceeding  max number
 of links set and generating the warning message.

 Our actions result in:
 * Post a comment to a post, WP queues this for approval, approve the
 comment to publish it, check activity stream to find no comment added.
 * Post comment as a subscriber from the activity stream to a post, exceed
 the allowed links, receives the error message and no comment posted, check
 the WP dashboard comment is listed but listed as 'Approved', contrary to
 what should be seen as a comment pending. Regardless of the comment
 existing in WP terms and approved it will never figure in activity stream.
 * Add a status update, exceed links allowed, receive error message,
 however the status update is actually accepted and displayed with no
 actual moderation and we can see the update in user screens and members
 loops.

 Given that `bp_core_check_for_moderation` isn't ready for prime time
 currently or at least the checks on act stream and updates are not able to
 tie into the WP queued pending approval the wise course of action is
 probably to pull this functionality altogether until #6719 can be
 addressed.

 Edit: In addition checking the function `bp_activity_check_blacklist_keys`
 demonstrates similar behaviour in preventing the posting of the commnet to
 a post from the activity stream however it manages to bypass the WP check
 and adds the comment without allowing WP to queue it pending aproval and
 thus it displays in the actual post.

 A patch will be added to remove:
 `bp_activity_check_moderation_keys()` &
 `bp_activity_check_blacklist_keys()`

--

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6822#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac