[buddypress-trac] [BuddyPress Trac] #6798: Prevent duplicate group membership request acceptance.

[buddypress-trac]

#6798: Prevent duplicate group membership request acceptance.
----------------------------------------+-----------------------
 Reporter:  dcavins                     |       Owner:  dcavins
     Type:  defect (bug)                |      Status:  assigned
 Priority:  normal                      |   Milestone:  2.5
Component:  Component - Groups          |     Version:  2.4.0
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+-----------------------
Changes (by boonebgorges):

 * owner:   => dcavins
 * status:  new => assigned
 * milestone:  Awaiting Review => 2.5


Comment:

 I'm guessing it's not reproducible in the case of unit tests because the
 tests run too quickly to allow the race condition to kick in. I wouldn't
 bother worrying about writing a repeatable test, I guess.

 The approach in [attachment:6798.01.patch] looks good to me, except that
 I'd think you should return `false` rather than `true`. In these cases,
 the membership is not, in fact, being accepted.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6798#comment:2>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac