[buddypress-trac] [BuddyPress Trac] #6896: Improve BP Emails templating
buddypress-trac
noreply at wordpress.org
Mon Feb 15 14:07:42 UTC 2016
#6896: Improve BP Emails templating
-----------------------------------------+------------------
Reporter: imath | Owner:
Type: defect (bug) | Status: new
Priority: normal | Milestone: 2.5
Component: Appearance - Template Parts | Version:
Severity: normal | Resolution:
Keywords: has-patch |
-----------------------------------------+------------------
Comment (by DJPaul):
Interesting. So, most of the Customizer pieces came from @timersys' Email
Template plugin -- actually, he patched it into BuddyPress for us, doing a
lot of work (https://github.com/paulgibbs/BuddyPress/pull/2/files) so big
thanks Damian. :)
His plugin removes all hooked actions and filters, see
https://github.com/paulgibbs/BuddyPress/issues/4#issuecomment-156811155
and
https://github.com/paulgibbs/BuddyPress/issues/4#issuecomment-156851463
* We needed `wp_footer` for the Customizer JS/CSS to work. But not the
header.
* I decided to not un-register all hooked actions from `wp_footer` because
I wanted to see what plugins would break this. Apparently Damian found
plugins that broke stuff, but I haven't yet, so there's a little risk
here.
I am not sure about adding `wp_head()` this late, although we could. But
Damian didn't find a need for it, and I haven't, until now. I'm not sure.
What do people think?
An alternate would be to hook `customize_preview_loading_style` into
wp_footer.
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6896#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list