[buddypress-trac] [BuddyPress Trac] #6894: BP Messages - Causes PHP Error - Wrong call of a function

[buddypress-trac]

#6894: BP Messages - Causes PHP Error - Wrong call of a function
-----------------------------------+---------------------
 Reporter:  Jon Ziemlich           |       Owner:  r-a-y
     Type:  defect (bug)           |      Status:  closed
 Priority:  normal                 |   Milestone:  2.4.4
Component:  Component - Messaging  |     Version:  2.4.0
 Severity:  normal                 |  Resolution:  fixed
 Keywords:  has-patch              |
-----------------------------------+---------------------
Changes (by r-a-y):

 * owner:   => r-a-y
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"10586"]:
 {{{
 #!CommitTicketReference repository="" revision="10586"
 Messages: Return generic WP Error in `messages_new_message()` when
 necessary.

 In #6535, we added an `'error_type'` parameter in `messages_new_message()`
 that supports returning a WP Error object if error type is set to
 `'wp_error'`.  However, we did not return a WP error further down in the
 `messages_new_message()` function, which can result in a potential fatal
 error to occur.

 This commit rectifies this and includes a unit test.

 Anti-props r-a-y.

 Fixes #6894 (2.4-branch).
 }}}

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6894#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac