[buddypress-trac] [BuddyPress Trac] #6859: WP Admin Bar - Sort "My Account" subnav items

[buddypress-trac]

#6859: WP Admin Bar - Sort "My Account" subnav items
----------------------------------------+--------------------
 Reporter:  r-a-y                       |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  2.5
Component:  General - Toolbar/BuddyBar  |     Version:  1.5.1
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch commit            |
----------------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:  has-patch => has-patch commit


Comment:

 This looks good to me, @r-a-y. Regarding the `$pos % 10 === 0` trick: The
 logic here seems right, though I guess there could be a problem if a
 plugin tried jamming more than 9 unordered admin bar items within a given
 range - it looks like every one after the eighth one would get `9`, which
 would make their sort order indeterminate? That said, this will probably
 never happen, and it's probably not a bigger bug than whatever happens now
 when you do this (they appear in the order in which they're added?)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6859#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac