[buddypress-trac] [BuddyPress Trac] #6873: Group notification email updates for bp_send_email() compatibility

[buddypress-trac]

#6873: Group notification email updates for bp_send_email() compatibility
--------------------------------+-----------------------
 Reporter:  dcavins             |      Owner:
     Type:  regression          |     Status:  new
 Priority:  high                |  Milestone:  2.5
Component:  Component - Groups  |    Version:
 Severity:  blocker             |   Keywords:  has-patch
--------------------------------+-----------------------
 In the class `BP_Email_Recipient`, the `recipient` argument is checked
 strictly for `is_int()`. However, many of the user_ids returned by group
 functions are numeric strings, so `BP_Email_Recipient` fails.

 Following is a list of the affected emails:
 * email `groups-details-updated` in `groups_notification_group_updated()`.
 Recipient user_ids are provided by
 `BP_Groups_Member::get_group_member_ids( $group->id )` which returns those
 ids as numeric strings.

 * email `groups-membership-request` in
 `groups_notification_new_membership_request()`. Recipient user_ids are
 provided by `groups_get_group_admins( $group_id )` which returns those ids
 as numeric strings.

 * emails `groups-membership-request-accepted` and `groups-membership-
 request-rejected` in `groups_notification_membership_request_completed()`.
 Recipient user_ids are provided by `BP_Groups_Member->user_id` which
 returns user_ids as numeric strings.

 * emails `groups-member-promoted` in
 `groups_notification_promoted_member()`. Recipient user_id is grabbed from
 an action variable, so is a string.

 * email `groups-invitation` in `groups_notification_group_invites()`.
 Recipient user_ids are provided by `BP_Groups_Member->user_id` which
 returns user_ids as numeric strings.

 Additionally, there are a couple of token mismatches in the `groups-
 invitation` email.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6873>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac