[buddypress-trac] [BuddyPress Trac] #6872: List table views can't be filtered

[buddypress-trac]

#6872: List table views can't be filtered
-----------------------------+---------------------------------------
 Reporter:  thebrandonallen  |      Owner:
     Type:  defect (bug)     |     Status:  new
 Priority:  normal           |  Milestone:  Awaiting Review
Component:  General - UX/UI  |    Version:  2.0
 Severity:  normal           |   Keywords:  has-patch has-screenshots
-----------------------------+---------------------------------------
 This ticket technically addresses two separate issues. However, since one
 exposes the other, I'm wrapping them both into one.

 The first issue is that the signups list table doesn't set the `screen`
 parameter in the constructor. This means them when you're on the `Pending`
 (signups) view, any custom views added via the `view_(users\users-
 network)` filter will disappear.

 The second issue, is that the `Pending` view is added in the `get_views()`
 method, on top of being added via filter. As long as you're on any view
 other than the `Pending` view, the filter kicks in. When on the `Pending`
 view, any other custom views added earlier than the `Pending` view will
 get bumped behind the pending view.

 The attached patch fixes both issues. The `get_views()` method can
 actually be removed, but I didn't want to make that decision, so the patch
 just calls `parent::get_views()`.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6872>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac