[buddypress-trac] [BuddyPress Trac] #6865: `bp_activity_get_actions()` should only sort when necessary

buddypress-trac noreply at wordpress.org
Wed Feb 3 10:14:23 UTC 2016

#6865: `bp_activity_get_actions()` should only sort when necessary
 Reporter:  boonebgorges                |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  2.5
Component:  Component - Activity        |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |

Comment (by imath):

 Replying to [comment:4 boonebgorges]:
 > I'm not sure why your approach in [attachment:6865.02.patch] works

 Actually it doesn't work that great :)

 The unit tests in 6865.unittests.patch are what i've thought of. They are
 passing in trunk and with your patch 6865.2.diff and my 6865.02.patch is
 failing the 3rd test

 But correct me if i'm wrong, your patch should have no impact if a post
 type is registered, actions should always be sorted each time
 bp_activity_get_actions() is used no ?
 What happens if a plugin is not using a post type for his action and is
 setting his action with a lower position than let's activity_update ?
 Would actions be sorted ?

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6865#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list