[buddypress-trac] [BuddyPress Trac] #6869: No more screen notifications for Activity mentions

[buddypress-trac]

#6869: No more screen notifications for Activity mentions
---------------------------------------+------------------
 Reporter:  imath                      |       Owner:
     Type:  defect (bug)               |      Status:  new
 Priority:  normal                     |   Milestone:  2.5
Component:  Component - Notifications  |     Version:
 Severity:  normal                     |  Resolution:
 Keywords:  needs-patch                |
---------------------------------------+------------------

Comment (by imath):

 @djpaul

 1) i don’t find the `'bp_sent_email'` `do_action()` or
 `do_action_ref_array()` in the code. It looks like it’s not fired or is it
 a dynamic action ?
 2) I think there’s something wrong here, screen notifications should
 happen whatever is the user preference for emails. If you look at the 2.4
 branch the `do_action( 'bp_activity_sent_mention_email' )` was always
 fired.  See https://buddypress.trac.wordpress.org/browser/branches/2.4/src
 /bp-activity/bp-activity-notifications.php#L147
 3) Core functions shouldn't hook to deprecated actions imho.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6869#comment:1>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac