[buddypress-trac] [BuddyPress Trac] #6863: Indentation fixes for `.scss` files

buddypress-trac noreply at wordpress.org
Tue Feb 2 12:27:07 UTC 2016

#6863: Indentation fixes for `.scss` files
 Reporter:  netweb                    |       Owner:  hnla
     Type:  defect (bug)              |      Status:  closed
 Priority:  normal                    |   Milestone:  2.5
Component:  Tools - Code Improvement  |     Version:
 Severity:  normal                    |  Resolution:  fixed
 Keywords:  has-patch                 |

Comment (by hnla):

 >I'll create a ticket and patch tomorrow for Stylelint and various other
 PostCSS plugins to enhance BP's CSS.

 Great stuff!

 >What exactly is wrong with the comments per the attached patch? They are
 now nested per WordPress CSS coding standards.

 :) No I think we're at cross purposes here, I'm referring to css comments
 if you add css comments within sass nested rulesets the compiler sees the
 comment as a property and expands it, you end up with:
 selector {
  /* the comment */

 Also I decided that it was better to remove commented out (not compiled)
 scss rulesets.

 This wasn't about coding standards per se, however please do base your
 scss stylelint rules on the .scs-lint.yml we have as we had a few changes
 in that.

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6863#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list