[buddypress-trac] [BuddyPress Trac] #6863: Indentation fixes for `.scss` files

buddypress-trac noreply at wordpress.org
Tue Feb 2 11:37:24 UTC 2016

#6863: Indentation fixes for `.scss` files
 Reporter:  netweb                    |       Owner:  hnla
     Type:  defect (bug)              |      Status:  accepted
 Priority:  normal                    |   Milestone:  2.5
Component:  Tools - Code Improvement  |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch                 |

Comment (by netweb):

 Replying to [comment:4 hnla]:
 > :)
 > >I get quite a bit of enjoyment and have a boat load of fun digging
 around these sorts of things
 > Wish I could say the same, or would do if I had that time. Sorting out a
 better linter though now a priority, when I have a minute I'll look at the
 suggestion you made on that other ticket where scsslint was an issue.
 The patch [attachment:6863.diff] was created using Stylelint, what I'm
 proposing to use as the replacement to the Ruby gem.

 I'll create a ticket and patch tomorrow for Stylelint and various other
 PostCSS plugins to enhance BP's CSS.

 > Thanks for the patch, I've actually had to go through the files as
 looking at these issues, suggested it was better to delete the commented
 out rulesets/properties for neatness and sadly and although I had
 accounted for the majority of css comments a few still existed where scss
 fails to be able to handle them as comments in nested selectors.
 > I'll commit changes in due course.

 What exactly is wrong with the comments per the attached patch? They are
 now nested per WordPress CSS coding standards.

 In my opinion the patch is fine as is, it is based on the WordPress CSS
 coding standards and the configuration I have created for Stylelint. It is
 quite concise and I've been constantly iterating on for ~6 months now. If
 something doesn't add up please let me know so any changes you think are
 needed can be added upstream as needed :)

Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6863#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac

More information about the buddypress-trac mailing list