[buddypress-trac] [BuddyPress Trac] #6865: `bp_activity_get_actions()` should only sort when necessary

[buddypress-trac]

#6865: `bp_activity_get_actions()` should only sort when necessary
----------------------------------------+------------------
 Reporter:  boonebgorges                |       Owner:
     Type:  enhancement                 |      Status:  new
 Priority:  normal                      |   Milestone:  2.5
Component:  Component - Activity        |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+------------------
Changes (by imath):

 * keywords:  has-patch => has-patch needs-unit-tests


Comment:

 Replying to [comment:1 boonebgorges]:
 > @imath, do you have any thoughts about this?

 My first thought is i agree saving overload is very important, but i think
 we must be careful to make sure things are still working the way they
 should :)

 I've tested your patch and the result is the activity actions are no more
 sorted. An easy way to reproduce is to activate the blogs component, and
 you'll see that comments with a 10 priority is above posts which have a 5
 priority, and this is wrong 5 should be displayed before 10.

 I've made some quick tests by using 2 times the
 `bp_activity_get_actions()` function and the only i've succeeded in making
 sure $_actions can be different than $bp->activity->actions is in
 .02.patch.

 I think we should have unit tests here, it could help us to see if we need
 an initial sort.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6865#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac