[buddypress-trac] [BuddyPress Trac] #6275: Missing plural on activities for show all comments button

[buddypress-trac]

#6275: Missing plural on activities for show all comments button
--------------------------------------+------------------
 Reporter:  danbp                     |       Owner:
     Type:  defect (bug)              |      Status:  new
 Priority:  normal                    |   Milestone:  2.8
Component:  I18N                      |     Version:
 Severity:  minor                     |  Resolution:
 Keywords:  good-first-bug has-patch  |
--------------------------------------+------------------
Changes (by slaFFik):

 * keywords:  needs-patch good-first-bug => good-first-bug has-patch
 * version:  2.2.1 =>


Comment:

 So, after some investigation here is what I've found:

 `'show_all' => __( 'Show all', 'buddypress' ),` - not used at all, be it
 seems we need to leave it for BC (not sure).

 `'show_all_comments' => __( 'Show all comments for this thread',
 'buddypress' ),` - it's a title attribute, so it's good to leave it for
 accessibility (right, @mercime?)

 `'show_x_comments' => __( 'Show all %d comments', 'buddypress' ),` - here
 is the source of the problem, when editing `buddypress.js` to show this
 show-more link, when there is 1 comment.
 The simplest solution: `'show_x_comments' => __( 'Show all comments (%d)',
 'buddypress' ),`.

 Attached images shows how it will look like, and patch - implement this
 change.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6275#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac