[buddypress-trac] [BuddyPress Trac] #6889: Remove usage of deprecated BP_Core_User::get_users()

[buddypress-trac]

#6889: Remove usage of deprecated BP_Core_User::get_users()
-------------------------+-----------------------
 Reporter:  tw2113       |       Owner:  tw2113
     Type:  enhancement  |      Status:  accepted
 Priority:  normal       |   Milestone:  2.8
Component:  Friends      |     Version:
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |
-------------------------+-----------------------

Comment (by tw2113):

 Attached is updated tests patch.

 So, interesting results. I have amended the tests patch to use "id"
 instead of "ID", after noticing the {{{BP_Core_User::get_users}}} version
 returned that as well as the newer, non-deprecated method. So that
 conflict should be resolved.

 However, with that taken care of, the tests pre-patch are mostly getting
 the deprecated notice for the original version. The one exception is the
 function to get users in alphabetical order. This has me thinking the
 current version of the function, which is not used by BP Core anyway, is
 actually buggy and not returning in alphabetical order.

 With the patched version above, removing the deprecated methods, the tests
 are passing cleanly. So in regards to the "back compat" topic, I think
 this is a case that we can accept, because of the new version passing
 cleanly. Updating from the deprecated methods, actually fixes an issue.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6889#comment:20>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac