[buddypress-trac] [BuddyPress Trac] #7349: When user is not logged , in he/she clicks email link to view new messages gets 404 page when should get login page

[buddypress-trac]

#7349: When user is not logged , in he/she clicks email link to view new messages
gets 404 page when should get login page
--------------------------+-----------------------------
 Reporter:  dkelm         |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Core          |     Version:
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |
--------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  dev-feedback => needs-patch
 * milestone:  Under Consideration => Future Release


Comment:

 I think we should fix this in a general way.

 Currently, subnav items with the `user_has_access=false` flag are never
 actually added to the component nav. The way it *should* work (and the way
 that `BP_Group_Extension` works, to some extent) is:
 - Separate the concept of 'access' (user can visit the tab) from the
 concept of 'visibility' (user can see the subnav item. `user_has_access`
 could maybe be a back-compat way of defining them both at the same time.
 - When `visibility=false`, don't add the nav item (or add it, but don't
 render it - this is a harder job, but maybe better in the long run). *Do*
 continue to register the screen function.
 - When `access=false`, the screen function should be `bp_core_no_access()`
 (or a wrapper with appropriate redirects).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7349#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac