[buddypress-trac] [BuddyPress Trac] #7374: Add new filter to bp_activity_do_heartbeat()
buddypress-trac
noreply at wordpress.org
Thu Dec 8 02:30:19 UTC 2016
#7374: Add new filter to bp_activity_do_heartbeat()
---------------------------------------+------------------
Reporter: wordpressrene | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.8
Component: Activity | Version:
Severity: normal | Resolution:
Keywords: good-first-bug needs-docs |
---------------------------------------+------------------
Changes (by boonebgorges):
* keywords: good-first-bug has-patch => good-first-bug needs-docs
Comment:
@wordpressrene Thank you very much for the patch! A few comments:
- New filters should be documented according to WordPress's inline
documentation standards: https://make.wordpress.org/core/handbook/best-
practices/inline-documentation-standards/php/#4-hooks-actions-and-filters.
- Please use tabs instead of spaces when indenting.
- We currently return early if `! bp_is_activity_heartbeat_active()`. If
we're going to add a filter to the function, perhaps we want to refactor
so that this value will be run through the filter as well.
Would you like to revise your patch, @wordpressrene ?
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7374#comment:4>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list