[buddypress-trac] [BuddyPress Trac] #7202: BP_XProfile_Query::find_compatible_table_alias uses field_id instead of field

[buddypress-trac]

#7202: BP_XProfile_Query::find_compatible_table_alias uses field_id instead of
field
------------------------------+-----------------------
 Reporter:  thomaslhotta      |       Owner:  r-a-y
     Type:  defect (bug)      |      Status:  assigned
 Priority:  normal            |   Milestone:  2.6.3
Component:  Extended Profile  |     Version:  2.2
 Severity:  normal            |  Resolution:
 Keywords:                    |
------------------------------+-----------------------
Changes (by r-a-y):

 * keywords:  needs-unit-tests =>
 * version:  2.6.1.1 => 2.2


Comment:

 > but I'm pretty sure @r-a-y ported it here :)

 @boone committed the changes - r9178 :)

 I do actually want to make a change here so `BP_XProfile_Query` extends
 `BP_Recursive_Query` to reduce code duplication.  Meant to do this awhile
 ago, but completely forgot about it.

 ----

 As for this issue, I've attached a unit test using `'relation' => 'AND',
 'compare' => 'NOT IN'`.  Patch passes using either `'field'` or
 `'field_id'`.  Meaning this isn't important enough to fix in a point
 release.

 I'm not sure if the table aliases are already optimized and whether line
 519 in `BP_XProfile_Query` is necessary or not.

 Would appreciate some feedback from Boone here.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7202#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac