[buddypress-trac] [BuddyPress Trac] #3961: Hierarchical groups

buddypress-trac noreply at wordpress.org
Mon Aug 8 16:19:58 UTC 2016


#3961: Hierarchical groups
------------------------------------------------+-----------------------
 Reporter:  sooskriszta                         |       Owner:  dcavins
     Type:  enhancement                         |      Status:  assigned
 Priority:  normal                              |   Milestone:  2.7
Component:  Groups                              |     Version:
 Severity:  normal                              |  Resolution:
 Keywords:  dev-feedback 2nd-opinion has-patch  |
------------------------------------------------+-----------------------

Comment (by dcavins):

 Replying to [comment:36 DJPaul]:
 > @dcavins I am probably misreading this but:
 >
 > `$child_group = groups_get_group( array( 'group_id' => $cgroup->id ) );`
 >
 > That block. Isn't `$cgroup` already the `$child_group` ??

 Ah. It's the group data, but not the `BP_Groups_Group` object that we need
 to call `save()` on.

 Re your earlier suggestions:
 I'm attaching a slightly different version of the minimal patch that
 reinstates the tests I had written to check the behavior of `parent_id`
 queries in the `BP_Groups_Group` class and the orphan-tidying function.
 (Somehow I left them out of the minimal patch, too.) Please let me know if
 there are other tests that you can think of--I'm happy to write them. I've
 also prefixed the function name to be consistent as suggested:
 `bp_groups_update_orphaned_groups_on_group_delete()`.

 Thanks again for taking a look at the patch.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/3961#comment:38>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac


More information about the buddypress-trac mailing list