[buddypress-trac] [BuddyPress Trac] #6932: Emails: real unsubscribe functionality

[buddypress-trac]

#6932: Emails: real unsubscribe functionality
----------------------------------------+---------------------------
 Reporter:  DJPaul                      |       Owner:  tharsheblows
     Type:  enhancement                 |      Status:  assigned
 Priority:  normal                      |   Milestone:  2.6
Component:  API - Emails                |     Version:
 Severity:  normal                      |  Resolution:
 Keywords:  has-patch needs-unit-tests  |
----------------------------------------+---------------------------

Comment (by boonebgorges):

 @tharsheblows Thanks so much for your work on this! It's a great feature,
 and I think the basic workflow is good.

 I have a number of comments about implementation details (function names
 and signatures, boring stuff like that), but before addressing them, I
 wanted to draw attention to the list of strings provided in
 `bp_emails_unsubscribe()` - 'You will no longer...' etc. It seems to me
 that these are properties of email types, so I wonder if we might change
 the logic of how these strings are generated somewhat. Briefly:

 - The strings are registered alongside the email types in
 `bp_email_schema()` or `bp_email_get_type_schema()`. I don't know if this
 will mean saving strings to the database or pulling them from somewhere at
 runtime.
 - Instead of using new identifiers for the notification type ("nt"), use
 the email type handles. Ie 'activity-at-message' instead of
 'notification_activity_new_mention'.
 - On unsubscription, pull the string from the schema to display on the
 unsubscribe page.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6932#comment:8>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac