[buddypress-trac] [BuddyPress Trac] #6534: A new API to manage single items navigation
buddypress-trac
noreply at wordpress.org
Tue Apr 26 23:21:05 UTC 2016
#6534: A new API to manage single items navigation
------------------------------------+------------------
Reporter: imath | Owner:
Type: enhancement | Status: new
Priority: high | Milestone: 2.6
Component: API | Version:
Severity: normal | Resolution:
Keywords: dev-feedback has-patch |
------------------------------------+------------------
Changes (by imath):
* keywords: dev-feedback needs-refresh => dev-feedback has-patch
Comment:
I've been thinking about this ticket and i'd like to suggest another
approach. I think the main problem is arrays are not "enough" to store our
nav items. So instead i'm suggesting to use a new object that will build
the nav for a given item id (group or member).
6534.02.patch is using a new class BP_Core_Item_Nav to build navs for the
displayed user and another one for the displayed group so that we avoid
slug collisions. Patch is fixing #5103 (you can test by creating a group
named "profile" before & after applying the patch)
As the Group has now the full control over the main nav, i guess we could
use it for the the future release in a more interesting way i'm doing in
the patch (i mimic the old bp_options_nav).
So i think unless somebody is directly setting/playing/editing
`$bp->bp_nav` or `$bp->bp_options_nav` this patch shouldn't break anything
and it will allow me to carry on working on #6026 ;)
Feedbacks welcome :)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6534#comment:19>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list