[buddypress-trac] [BuddyPress Trac] #5500: Date xprofile field enhancement
buddypress-trac
noreply at wordpress.org
Fri Apr 22 14:52:29 UTC 2016
#5500: Date xprofile field enhancement
----------------------------------+------------------
Reporter: sooskriszta | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.6
Component: Component - XProfile | Version:
Severity: normal | Resolution:
Keywords: needs-patch |
----------------------------------+------------------
Comment (by boonebgorges):
Thanks very much, @abwebstudio. I think the UI is getting close to being
very good. There are a few things I would change with the wording
("Custom" instead of "Arbitrarily"; add a link to date formatting rules,
like WP has; "Range" instead of "Year Range"; etc) but I really like the
general workflow here. Very powerful, and quite usable.
The internals of the patch still need lots of reworking, in accordance
with some of the comments I made above about coding standards, data
storage, and so forth. In addition to this, I'd like to consider a few
more pieces before considering for merge:
- It would be nice to have unit tests for some of the range stuff. We
don't need extensive tests for PHP's date format functions, but the range
stuff is custom, so I think it's worth testing.
- In Edit mode, Month should only be shown when Month will show in the
interface, etc.
- Validation for custom date formats. WP does this using AJAX, in the form
of a preview - it doesn't tell you when you've entered an "invalid" date
format, since there's no real "invalid" - unrecognized characters are
interpreted by `date()` as literals. I think we should copy what WP does
here.
@abwebstudio If you're willing to continue working on these items, it'd
get this ticket done faster. Otherwise I'm interested in shepherding it
along myself, though it may not happen for this release if it's solely in
my court.
Thanks for your continued work! Cool feature!
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/5500#comment:38>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list