[buddypress-trac] [BuddyPress Trac] #7024: BP no longer filters `wp_mail_from_name` when using `wp_mail()`

[buddypress-trac]

#7024: BP no longer filters `wp_mail_from_name` when using `wp_mail()`
--------------------------+------------------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Awaiting Review
Component:  API           |     Version:  2.5.0
 Severity:  normal        |  Resolution:
 Keywords:                |
--------------------------+------------------------------

Comment (by DJPaul):

 https://github.com/paulgibbs/BuddyPress/commit/2a621518d4f2eb39c848c2b96999e952b853fefe
 was the commit for this during development.

 As things stand, we use the site name (option `blogname`) for the default
 value of the "From name" property.  When you set `blogname` in WordPress,
 it's sanitized with `esc_html` via `sanitize_option` before being stored
 in the database. Email from/reply to/bbc/cc "names" should not be HTML
 escaped otherwise you can end up with odd-looking values in the email,
 which in my testing sometimes caused deliverability issue.

 In this patch, as we've fixed `wp_mail_from_name` support for your edge
 case (IMO - it wasn't a use case I had considered during development), I
 figured falling back to use its default value of "WordPress" rather than
 `blogname` made sense for consistency with `wp_mail`.

 And then the now-deprecated function you found which filters in the
 `blogname` value for us, results in no change from current 2.5 behaviour,
 except we fix the problem you reported for people using `wp_mail` on a
 BuddyPress site.


 (The patch obviously needs to reinstate the old function, I was just
 looking at the filtering aspect).

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7024#comment:7>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac