[buddypress-trac] [BuddyPress Trac] #7020: bp_notifications_get_notifications_for_user() bug

[buddypress-trac]

#7020: bp_notifications_get_notifications_for_user() bug
--------------------------+-----------------------------
 Reporter:  rogercoathup  |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  Awaiting Review
Component:  API           |    Version:  2.5.0
 Severity:  normal        |   Keywords:
--------------------------+-----------------------------
 We pass an array to apply_filters_ref_array in
 bp_notifications_get_notifications_for_user()

 i.e.
 {{{#!php
 <?php
 $ref_array = array(
         $component_action_name,
         $component_action_items[0]->item_id,
         $component_action_items[0]->secondary_item_id,
         $action_item_count,
         $format
 );
 }}}


 The first parameter should be modifiable content for filtering, not the
 action name.

 With the current setup, if a hook returns content, the action name is
 overwritten in apply_filters_ref_array() and invalid in any subsequent
 hooks hooked on bp_notifications_get_notifications_for_user.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7020>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac