[buddypress-trac] [BuddyPress Trac] #7007: RTL CSS generation: Switch from CSSJanus to RTLCSS

[buddypress-trac]

#7007: RTL CSS generation: Switch from CSSJanus to RTLCSS
-------------------------------------+------------------
 Reporter:  netweb                   |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  2.6
Component:  Tools - Build Process    |     Version:
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |
-------------------------------------+------------------

Comment (by netweb):

 Refreshed patch in [attachment:7007.1.patch]:

 [attachment:7007.1.patch] refresh this now includes `extDot: 'last'`:
 * Prevents `jquery-rtl.css` from being created at `src/bp-
 messages/css/autocomplete/` from
 [https://buddypress.trac.wordpress.org/browser/trunk/src/bp-
 messages/css/autocomplete/jquery.autocompletefb.css /src/bp-
 messages/css/autocomplete/jquery.autocompletefb.css]

 * Includes the ignore RTL synax change from CSSJanus' `/* @noflip */ to
 RTLCss' `/* rtl:ignore */` in `src/bp-activity/css/mentions.css`

 [attachment:7007-src.diff] This is the `/src` folder diff after running
 `grunt release` (Includes the original [attachment:7007.1.patch])
 * 1st `src/bp-activity/css/mentions-rtl.css`
 * 2nd `src/bp-core/css/buddybar-rtl.css`
 * 3rd `src/bp-messages/css/autocomplete/jquery.autocompletefb-rtl.css`

 [attachment:7007-build.diff]  This is the `/build` folder diff after
 running `grunt release`

 * 1st `bp-core/css/buddybar-rtl.min.css` via 2nd `/src` change above in
 `src/bp-core/css/buddybar-rtl.css`
 * 2nd `bp-messages/css/autocomplete/jquery.autocompletefb-rtl.min.css` via
 3rd `/src` change above in `src/bp-messages/css/autocomplete/jquery
 .autocompletefb-rtl.css`
 * There is no new/change/minified from the `st `/src` change above in `src
 /bp-activity/css/mentions-rtl.css` or `src/bp-activity/css/mentions.css`
 files in the `/build` folder because the only difference is the RTL ignore
 comment, and comments are stripped from minified CSS and with that there
 are no differences in the minified CSS between CSSJanus and RTLCSS

 Steps to finish up this ticket:

 Apply [attachment:7007.1.patch] and run `grunt build`, after that running
 `svn diff` or `git diff` should result in a patch identical to
 [attachment:7007-src.diff], commit the changes separately or together,
 chose your own adventure :)

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/7007#comment:3>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac