[buddypress-trac] [BuddyPress Trac] #6966: Email Subject special characters display problem with initiator.name token (BuddyPress v2.5.1)

[buddypress-trac]

#6966: Email Subject special characters display problem with initiator.name token
(BuddyPress v2.5.1)
--------------------------+--------------------
 Reporter:  richdal       |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  high          |   Milestone:  2.5.3
Component:  API - Emails  |     Version:  2.5.0
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |
--------------------------+--------------------
Changes (by r-a-y):

 * keywords:  needs-patch => has-patch


Comment:

 @DJPaul - I've attached a patch for the email subject decoding issue.

 What we were lacking was HTML decoding when fetching the email subject.
 I'm also switching when we use `html_entity_decode()`; we should only do
 this when `$transform` is set to `replace-tokens`.

 I've also modified the unit tests.  The first test in `tests-in-
 progress.diff` uses `wptexturize()`, which will not be used; when we fetch
 the email post, post title is always raw.  Second test has been
 simplified.

 Let me know what you think.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6966#comment:12>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac