[buddypress-trac] [BuddyPress Trac] #6372: Use "Mystery Group" avatar when group avatar not available.
buddypress-trac
noreply at wordpress.org
Fri Apr 8 04:47:10 UTC 2016
#6372: Use "Mystery Group" avatar when group avatar not available.
-----------------------------------+------------------
Reporter: sooskriszta | Owner:
Type: enhancement | Status: new
Priority: normal | Milestone: 2.6
Component: Component - Groups | Version:
Severity: normal | Resolution:
Keywords: has-patch 2nd-opinion |
-----------------------------------+------------------
Changes (by boonebgorges):
* keywords: needs-patch => has-patch 2nd-opinion
* type: defect (bug) => enhancement
* milestone: Future Release => 2.6
Comment:
Image looks great.
[attachment:6372.diff] makes the following improvements:
* I changed the implementation a little bit so that the default kicks in
before the 'bp_core_default_avatar_group' filter. This ensures that
existing filters here will continue to work as expected.
* Added a 50x50 image, and support for loading the thumbnail version when
necessary.
Question for the team: Why do we ever ping Gravatar for group images? They
will never match. I guess if you're getting a Wavatar or some other
generated image, maybe you want the variety? In [attachment:6372.diff] I
completely disabled Gravatar for group images, but maybe this is too
extreme. Maybe we should only disable if `avatar_default` is set to `mm`?
(See #4571 and [7769].)
--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6372#comment:10>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac
More information about the buddypress-trac
mailing list