[buddypress-trac] [BuddyPress Trac] #6694: filter for $after_member_slug in bp-core-catchuri.php

[buddypress-trac]

#6694: filter for $after_member_slug in bp-core-catchuri.php
-----------------------------------------+--------------------
 Reporter:  kmb@…                        |       Owner:
     Type:  enhancement                  |      Status:  new
 Priority:  normal                       |   Milestone:  2.6
Component:  API - Rewrite Rules          |     Version:  2.3.3
 Severity:  normal                       |  Resolution:
 Keywords:  has-patch reporter-feedback  |
-----------------------------------------+--------------------
Changes (by boonebgorges):

 * keywords:  good-first-bug needs-patch 2nd-opinion => has-patch reporter-
     feedback


Comment:

 I don't have a problem adding a filter, but putting it inside this
 conditional block seems like it limits its functionality (and has the
 potential to introduce bugs). See [attachment:6694.diff]. This will make
 callbacks somewhat more complicated; in the situation described by
 @kmb at deam.org, there may have to be an additional `if ( false !==
 $after_member_slug )` check inside `TEST_de_anonymize_url()`. But this
 seems like a reasonable trade-off for a much more flexible filter.

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6694#comment:6>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac