[buddypress-trac] [BuddyPress Trac] #6388: Groups single item home : improve the way we deal with custom front and activity component

[buddypress-trac]

#6388: Groups single item home : improve the way we deal with custom front and
activity component
-------------------------------------------------+-------------------------
 Reporter:  imath                                |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  2.4
Component:  Component - Groups                   |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch 2nd-opinion needs-testing  |
  needs-docs                                     |
-------------------------------------------------+-------------------------
Changes (by imath):

 * type:  enhancement => defect (bug)


Comment:

 @DJPaul i understand your concerns. And i'm ok to change the function name
 to whatever suits best :)

 I really hope @mercime and @hnla will have a look to the proposed template
 hierarchy improvements suggested etc..

 This ticket is really a stone in my shoe. And it hurts me bad, each time i
 think about it :)

 So i'd really like if we could solve what i consider now as a several
 bugs:
 - when a group has a custom template, it's losing the activity feature.
 - when the activity component is disable and the group has no custom
 front, it has 2 members tab (home & members)
 - we are using `bp_is_group_home()` to check if we are in the activity
 area of the group which is in my opinion wrong as the group can have a
 custom template. the right check needs to be `bp_is_group_activity()`

 So the 6388.02.patch is updated to trunk and now includes some
 improvements to `bp_is_group_activity()` & `bp_is_group_member()`

--
Ticket URL: <https://buddypress.trac.wordpress.org/ticket/6388#comment:5>
BuddyPress Trac <http://buddypress.org/>
BuddyPress Trac